GH-125: Allow null timestamp holder sans timezone #941
+217
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaustav-Sarkar
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Please set labels, I do not have permission |
lidavidm
changed the title
lidavidm
changed the title
lidavidm
reviewed
Dec 30, 2025
Member
There was a problem hiding this comment.
I think it'd be more natural to move the else block below as the second conditional check, so we aren't repeating boolean clauses.
Member
There was a problem hiding this comment.
I agree, it looks more "logical".
jbonofre
approved these changes
Dec 30, 2025
| "holder.timezone: %s not equal to vector timezone: %s", | ||
| holder.timezone, this.timeZone)); | ||
| } else if (holder.isSet > 0) { | ||
| if (!this.timeZone.equals(holder.timezone)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an
IllegalArgumentExceptioninTimeStamp*TZVector.set/setSafewhen unsetting values using a holder with anulltimezone. The validation logic now correctly ignores the timezone check whenholder.isSet <= 0, allowing default-constructed holders to be used for unsetting values as expected.Comprehensive tests added for all timestamp precisions (Micro, Milli, Nano, Sec) to verify the fix and ensure the existing workaround (setting explicit timezone) remains supported.
Closes #125 .